Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #31

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Update README.md #31

merged 1 commit into from
Jun 13, 2024

Conversation

FenneRiemslagh
Copy link
Collaborator

I removed the italic sentence and added a lesson description.

Fixes issue #6

I removed the italic sentence and added a lesson description.
Copy link

github-actions bot commented Jun 13, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/DCC-Rpackaging-lesson/compare/md-outputs..md-outputs-PR-31

The following changes were observed in the rendered markdown documents:


What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-06-13 12:07:36 +0000

github-actions bot pushed a commit that referenced this pull request Jun 13, 2024
Copy link

@svenvanderburg svenvanderburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FenneRiemslagh for the effort. Go ahead and merge it!

@@ -1,6 +1,6 @@
# Packaging with R

*We need a sentence here that describes what this lesson is about.*
This lesson is about creating your own R-package.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good

@FenneRiemslagh FenneRiemslagh merged commit 03a213a into main Jun 13, 2024
3 checks passed
@FenneRiemslagh FenneRiemslagh deleted the FenneRiemslagh-patch-1 branch June 13, 2024 12:10
@FenneRiemslagh
Copy link
Collaborator Author

Thanks Sven for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants